Reload dynamics fields on files management to prevent issues

closes #1552

diff --git a/galette/lib/Galette/Entity/DynamicFieldsHandle.php b/galette/lib/Galette/Entity/DynamicFieldsHandle.php
index dece2243fb98d3c3c212cf780c6249fc41cc09b4..ea7212d907094de7a6d729bf9f8b1d24afa071c3 100644 (file)
--- a/galette/lib/Galette/Entity/DynamicFieldsHandle.php
+++ b/galette/lib/Galette/Entity/DynamicFieldsHandle.php
@@ -439,7 +439,7 @@ class DynamicFieldsHandle
     }
 
     /**
-     * Is there any change in dynamic filelds?
+     * Is there any change in dynamic fields?
      *
      * @return boolean
      */

diff --git a/galette/lib/Galette/Entity/DynamicsTrait.php b/galette/lib/Galette/Entity/DynamicsTrait.php
index 3439cec2718e0f450627778aa6bba4d37a268168..8ba16c31c4b0d38d7e2b33450beb8751b91f0629 100644 (file)
--- a/galette/lib/Galette/Entity/DynamicsTrait.php
+++ b/galette/lib/Galette/Entity/DynamicsTrait.php
@@ -249,13 +249,7 @@ trait DynamicsTrait
      */
     protected function dynamicsFiles($files)
     {
-        if ($this->dynamics === null) {
-            Analog::log(
-                'Dynamics fields have not been loaded, cannot be stored. (from: ' . __METHOD__ . ')',
-                Analog::WARNING
-            );
-            $this->loadDynamicFields();
-        }
+        $this->loadDynamicFields();
         $fields = $this->dynamics->getFields();
         $store = false;