Cannot set member as its own parent; closes #1806

diff --git a/galette/lib/Galette/Entity/Adherent.php b/galette/lib/Galette/Entity/Adherent.php
index 8234f6c7de0f74eedf15721c270f9648a1754192..5b0a5968be62b6b4bae9c2cbcf4797d8972cfbdd 100644 (file)
--- a/galette/lib/Galette/Entity/Adherent.php
+++ b/galette/lib/Galette/Entity/Adherent.php
@@ -1478,8 +1478,14 @@ class Adherent
                 }
                 break;
             case 'parent_id':
-                $this->$prop = ($value instanceof Adherent) ? (int)$value->id : (int)$value;
-                $this->loadParent();
+                $pid = ($value instanceof Adherent) ? (int)$value->id : (int)$value;
+                if ($pid === $this->id) {
+                    $this->errors[] = _T("A member cannot be its own parent!");
+                    $this->$prop = null;
+                } else {
+                    $this->$prop = $pid;
+                    $this->loadParent();
+                }
                 break;
         }
     }