Improve and fix tests

diff --git a/galette/lib/Galette/Core/Galette.php b/galette/lib/Galette/Core/Galette.php
index 1fb36e070888f07ce13dbf1588f4c0ba45026a78..38234cb6f114cd1933c928109d32fe3927fbe512 100644 (file)
--- a/galette/lib/Galette/Core/Galette.php
+++ b/galette/lib/Galette/Core/Galette.php
@@ -633,7 +633,7 @@ class Galette
             );
         }
 
-        if (!$login->isSuperAdmin()) {
+        if ($login->isLogged() && !$login->isSuperAdmin()) {
             // Single member
             $dashboards = array_merge(
                 $dashboards,

diff --git a/tests/Galette/Core/tests/units/Galette.php b/tests/Galette/Core/tests/units/Galette.php
index 6a5fdd82426f3edb30f63c947e5e2e77848b02b2..bf35cbbb41327cf58bafff9636b11fe30ccb622c 100644 (file)
--- a/tests/Galette/Core/tests/units/Galette.php
+++ b/tests/Galette/Core/tests/units/Galette.php
@@ -53,6 +53,8 @@ use Galette\GaletteTestCase;
  */
 class Galette extends GaletteTestCase
 {
+    protected int $seed = 20230324120838;
+
     /**
      * Test gitVersion
      *
@@ -145,4 +147,342 @@ class Galette extends GaletteTestCase
         $this->session->transaction_filter_test = $transaction_filter;
         $this->assertInstanceOf(\Galette\Filters\TransactionsList::class, $this->session->transaction_filter_test);
     }
+
+    /**
+     * Test getMenus
+     *
+     * @return void
+     */
+    public function testGetMenus()
+    {
+        global $preferences, $login, $plugins;
+        $db = new \Galette\Core\Db();
+        $plugins = new \Galette\Core\Plugins($db);
+        $preferences = $this->getMockBuilder(\Galette\Core\Preferences::class)
+            ->setConstructorArgs(array($db))
+            ->onlyMethods(array('showPublicPages'))
+            ->getMock();
+
+        $preferences->method('showPublicPages')->willReturn(true);
+
+        $menus = \Galette\Core\Galette::getMenus();
+        $this->assertIsArray($menus);
+        $this->assertCount(0, $menus);
+
+        $menus = \Galette\Core\Galette::getMenus(true);
+        $this->assertIsArray($menus);
+        $this->assertCount(1, $menus);
+        $this->assertArrayHasKey('public', $menus);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(true);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $menus = \Galette\Core\Galette::getMenus(true);
+        $this->assertIsArray($menus);
+        $this->assertCount(6, $menus);
+
+        $this->assertArrayHasKey('myaccount', $menus);
+        $this->assertArrayHasKey('members', $menus);
+        $this->assertArrayHasKey('contributions', $menus);
+        $this->assertArrayHasKey('management', $menus);
+        $this->assertArrayHasKey('configuration', $menus);
+        $this->assertArrayHasKey('public', $menus);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(false);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $menus = \Galette\Core\Galette::getMenus(true);
+        $this->assertIsArray($menus);
+        $this->assertCount(5, $menus);
+
+        $this->assertArrayHasKey('myaccount', $menus);
+        $this->assertArrayHasKey('members', $menus);
+        $this->assertArrayHasKey('contributions', $menus);
+        $this->assertArrayHasKey('management', $menus);
+        $this->assertArrayNotHasKey('configuration', $menus);
+        $this->assertArrayHasKey('public', $menus);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(true);
+        $login->method('isSuperAdmin')->willReturn(true);
+
+        $menus = \Galette\Core\Galette::getMenus(true);
+        $this->assertIsArray($menus);
+        $this->assertCount(5, $menus);
+
+        $this->assertArrayNotHasKey('myaccount', $menus);
+        $this->assertArrayHasKey('members', $menus);
+        $this->assertArrayHasKey('contributions', $menus);
+        $this->assertArrayHasKey('management', $menus);
+        $this->assertArrayHasKey('configuration', $menus);
+        $this->assertArrayHasKey('public', $menus);
+    }
+
+    /**
+     * Test getPublicMenus
+     *
+     * @return void
+     */
+    public function testGetPublicMenus()
+    {
+        global $preferences;
+
+        $db = new \Galette\Core\Db();
+        $preferences = $this->getMockBuilder(\Galette\Core\Preferences::class)
+            ->setConstructorArgs(array($db))
+            ->onlyMethods(array('showPublicPages'))
+            ->getMock();
+        $preferences->method('showPublicPages')->willReturn(false);
+
+        $menus = \Galette\Core\Galette::getPublicMenus();
+        $this->assertIsArray($menus);
+        $this->assertCount(0, $menus);
+
+        $preferences = $this->getMockBuilder(\Galette\Core\Preferences::class)
+            ->setConstructorArgs(array($db))
+            ->onlyMethods(array('showPublicPages'))
+            ->getMock();
+        $preferences->method('showPublicPages')->willReturn(true);
+
+        $menus = \Galette\Core\Galette::getPublicMenus();
+        $this->assertIsArray($menus);
+        $this->assertCount(1, $menus);
+    }
+
+    /**
+     * Test getDashboards
+     *
+     * @return void
+     */
+    public function testGetDashboards()
+    {
+        global $login;
+
+        $db = new \Galette\Core\Db();
+
+        $dashboards = \Galette\Core\Galette::getDashboards();
+        $this->assertCount(0, $dashboards);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(true);
+        $login->method('isSuperAdmin')->willReturn(true);
+
+        $dashboards = \Galette\Core\Galette::getDashboards();
+        $this->assertCount(8, $dashboards);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(true);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $dashboards = \Galette\Core\Galette::getDashboards();
+        $this->assertCount(11, $dashboards);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(false);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $dashboards = \Galette\Core\Galette::getDashboards();
+        $this->assertCount(9, $dashboards);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(false);
+        $login->method('isAdmin')->willReturn(false);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $dashboards = \Galette\Core\Galette::getDashboards();
+        $this->assertCount(3, $dashboards);
+    }
+
+    /**
+     * Test getListActions
+     *
+     * @return void
+     */
+    public function testGetListActions()
+    {
+        global $login;
+
+        $db = new \Galette\Core\Db();
+        $member = $this->getMemberOne();
+
+        $actions = \Galette\Core\Galette::getListActions($member);
+        $this->assertCount(0, $actions);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(true);
+        $login->method('isSuperAdmin')->willReturn(true);
+
+        $actions = \Galette\Core\Galette::getListActions($member);
+        $this->assertCount(4, $actions);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(true);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $actions = \Galette\Core\Galette::getListActions($member);
+        $this->assertCount(3, $actions);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(false);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $actions = \Galette\Core\Galette::getListActions($member);
+        $this->assertCount(3, $actions);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(false);
+        $login->method('isAdmin')->willReturn(false);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $actions = \Galette\Core\Galette::getListActions($member);
+        $this->assertCount(0, $actions);
+    }
+
+    /**
+     * Test getDetailledActions
+     *
+     * @return void
+     */
+    public function testGetDetailledActions()
+    {
+        $member = $this->getMemberOne();
+
+        //no core actions yet
+        $actions = \Galette\Core\Galette::getDetailedActions($member);
+        $this->assertCount(0, $actions);
+    }
+
+    /**
+     * Test getBatchActions
+     *
+     * @return void
+     */
+    public function testGetBatchActions()
+    {
+        global $login;
+
+        $db = new \Galette\Core\Db();
+        $member = $this->getMemberOne();
+
+        $actions = \Galette\Core\Galette::getBatchActions();
+        $this->assertCount(0, $actions);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(true);
+        $login->method('isSuperAdmin')->willReturn(true);
+
+        $actions = \Galette\Core\Galette::getBatchActions();
+        $this->assertCount(7, $actions);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(true);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $actions = \Galette\Core\Galette::getBatchActions();
+        $this->assertCount(7, $actions);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(true);
+        $login->method('isAdmin')->willReturn(false);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $actions = \Galette\Core\Galette::getBatchActions();
+        $this->assertCount(7, $actions);
+
+        $login = $this->getMockBuilder(\Galette\Core\Login::class)
+            ->setConstructorArgs(array($db, new \Galette\Core\I18n()))
+            ->onlyMethods(array('isLogged', 'isStaff', 'isAdmin', 'isSuperAdmin'))
+            ->getMock();
+
+        $login->method('isLogged')->willReturn(true);
+        $login->method('isStaff')->willReturn(false);
+        $login->method('isAdmin')->willReturn(false);
+        $login->method('isSuperAdmin')->willReturn(false);
+
+        $actions = \Galette\Core\Galette::getBatchActions();
+        $this->assertCount(0, $actions);
+    }
 }

diff --git a/tests/Galette/Core/tests/units/Links.php b/tests/Galette/Core/tests/units/Links.php
index 87c0e8df892d3f337c78188cbf97ed89d1c3d492..ebbceec33f779a871895b24f407dca48c4fe1a33 100644 (file)
--- a/tests/Galette/Core/tests/units/Links.php
+++ b/tests/Galette/Core/tests/units/Links.php
@@ -98,7 +98,6 @@ class Links extends GaletteTestCase
         $delete = $this->zdb->delete(\Galette\Core\Links::TABLE);
         $this->zdb->execute($delete);
 
-        $this->cleanHistory();
         parent::tearDown();
     }
 
@@ -125,7 +124,7 @@ class Links extends GaletteTestCase
         $this->assertSame(1, $results->count());
 
         $this->assertSame(
-            $links->isHashValid($res, 'phoarau@tele2.fr'),
+            $links->isHashValid($res, $this->adh->getEmail()),
             [
                 \Galette\Core\Links::TARGET_MEMBERCARD,
                 $id
@@ -133,7 +132,7 @@ class Links extends GaletteTestCase
         );
 
         $this->assertFalse($links->isHashValid($res, 'any@mail.com'));
-        $this->assertFalse($links->isHashValid(base64_encode('sthingthatisnotahash'), 'phoarau@tele2.fr'));
+        $this->assertFalse($links->isHashValid(base64_encode('sthingthatisnotahash'), $this->adh->getEmail()));
 
         $this->createContribution();
         $cid = $this->contrib->id;
@@ -144,7 +143,7 @@ class Links extends GaletteTestCase
 
         $this->assertNotEmpty($res);
         $this->assertSame(
-            $links->isHashValid($res, 'phoarau@tele2.fr'),
+            $links->isHashValid($res, $this->adh->getEmail()),
             [
                 \Galette\Core\Links::TARGET_INVOICE,
                 $cid
@@ -171,7 +170,7 @@ class Links extends GaletteTestCase
         $this->assertNotEmpty($res);
 
         $this->assertSame(
-            $links->isHashValid($res, 'phoarau@tele2.fr'),
+            $links->isHashValid($res, $this->adh->getEmail()),
             [
                 \Galette\Core\Links::TARGET_MEMBERCARD,
                 $id
@@ -190,7 +189,7 @@ class Links extends GaletteTestCase
             ->where(['hash' => base64_decode($res)]);
         $this->zdb->execute($update);
 
-        $this->assertFalse($links->isHashValid($res, 'phoarau@tele2.fr'));
+        $this->assertFalse($links->isHashValid($res, $this->adh->getEmail()));
     }
 
     /**

diff --git a/tests/Galette/Entity/tests/units/Adherent.php b/tests/Galette/Entity/tests/units/Adherent.php
index 90708df8c8f3b434b75dba5ba935191690ae793d..00d9a515f46e12f981a15e1566604e32f989d001 100644 (file)
--- a/tests/Galette/Entity/tests/units/Adherent.php
+++ b/tests/Galette/Entity/tests/units/Adherent.php
@@ -63,6 +63,7 @@ class Adherent extends GaletteTestCase
      */
     public function tearDown(): void
     {
+        parent::tearDown();
         $this->zdb = new \Galette\Core\Db();
 
         $delete = $this->zdb->delete(\Galette\Entity\Adherent::TABLE);
@@ -73,8 +74,18 @@ class Adherent extends GaletteTestCase
         $delete = $this->zdb->delete(\Galette\Entity\Adherent::TABLE);
         $delete->where(['fingerprint' => 'FAKER' . $this->seed]);
         $this->zdb->execute($delete);
+    }
 
-        $this->cleanHistory();
+    /**
+     * Cleanup after class
+     *
+     * @return void
+     */
+    public static function tearDownAfterClass(): void
+    {
+        $self = new self(__METHOD__);
+        $self->setUp();
+        $self->tearDown();
     }
 
     /**

diff --git a/tests/Galette/Entity/tests/units/Contribution.php b/tests/Galette/Entity/tests/units/Contribution.php
index c8a0045bd86b692fa5823dd4f15bbfb98dcefda1..862e9e86331aea4989a0bd7be2b89598f1dd8d8d 100644 (file)
--- a/tests/Galette/Entity/tests/units/Contribution.php
+++ b/tests/Galette/Entity/tests/units/Contribution.php
@@ -77,8 +77,6 @@ class Contribution extends GaletteTestCase
         $delete = $this->zdb->delete(\Galette\Entity\Adherent::TABLE);
         $delete->where(['fingerprint' => 'FAKER' . $this->seed]);
         $this->zdb->execute($delete);
-
-        $this->cleanHistory();
     }
 
     /**

diff --git a/tests/Galette/Entity/tests/units/FieldsConfig.php b/tests/Galette/Entity/tests/units/FieldsConfig.php
index c3daf0e1cb8f1320bf78b926b7c2026e7a93c5ea..91cce20530dfe575006e52712120da436a17e105 100644 (file)
--- a/tests/Galette/Entity/tests/units/FieldsConfig.php
+++ b/tests/Galette/Entity/tests/units/FieldsConfig.php
@@ -67,9 +67,9 @@ class FieldsConfig extends TestCase
     {
         $this->zdb = new \Galette\Core\Db();
 
-        include_once GALETTE_ROOT . 'includes/fields_defs/members_fields.php';
+        include GALETTE_ROOT . 'includes/fields_defs/members_fields.php';
         $this->members_fields = $members_fields;
-        include_once GALETTE_ROOT . 'includes/fields_defs/members_fields_cats.php';
+        include GALETTE_ROOT . 'includes/fields_defs/members_fields_cats.php';
         $this->members_fields_cats = $members_fields_cats;
 
         $this->fields_config = new \Galette\Entity\FieldsConfig(

diff --git a/tests/Galette/Entity/tests/units/ListsConfig.php b/tests/Galette/Entity/tests/units/ListsConfig.php
index b5e7f2934781ddd4bb4a6d5583101736e7865795..fdbb70a1c7e5459c0e52578f7e3bab404f331243 100644 (file)
--- a/tests/Galette/Entity/tests/units/ListsConfig.php
+++ b/tests/Galette/Entity/tests/units/ListsConfig.php
@@ -75,9 +75,9 @@ class ListsConfig extends TestCase
     {
         $this->zdb = new \Galette\Core\Db();
 
-        include_once GALETTE_ROOT . 'includes/fields_defs/members_fields.php';
+        include GALETTE_ROOT . 'includes/fields_defs/members_fields.php';
         $this->members_fields = $members_fields;
-        include_once GALETTE_ROOT . 'includes/fields_defs/members_fields_cats.php';
+        include GALETTE_ROOT . 'includes/fields_defs/members_fields_cats.php';
         $this->members_fields_cats = $members_fields_cats;
 
         $this->lists_config = new \Galette\Entity\ListsConfig(

diff --git a/tests/Galette/Entity/tests/units/PdfModel.php b/tests/Galette/Entity/tests/units/PdfModel.php
index 978abb1d4888ee2dba0cd22bbc59584e331512c1..9dfcac2a72cca2617900b113764e0b8355af70f6 100644 (file)
--- a/tests/Galette/Entity/tests/units/PdfModel.php
+++ b/tests/Galette/Entity/tests/units/PdfModel.php
@@ -320,32 +320,7 @@ class PdfModel extends GaletteTestCase
         ], \ArrayObject::ARRAY_AS_PROPS);
         $model = new \Galette\Entity\PdfInvoice($this->zdb, $this->preferences, $rs);
 
-        $data = [
-            'nom_adh' => 'Durand',
-            'prenom_adh' => 'René',
-            'ville_adh' => 'Martel',
-            'cp_adh' => '39 069',
-            'adresse_adh' => '66, boulevard De Oliveira',
-            'email_adh' => 'meunier.josephine@ledoux.com',
-            'login_adh' => 'arthur.hamon',
-            'mdp_adh' => 'J^B-()f',
-            'mdp_adh2' => 'J^B-()f',
-            'bool_admin_adh' => false,
-            'bool_exempt_adh' => false,
-            'bool_display_info' => true,
-            'sexe_adh' => 0,
-            'prof_adh' => 'Chef de fabrication',
-            'titre_adh' => null,
-            'ddn_adh' => '1937-12-26',
-            'lieu_naissance' => 'Gonzalez-sur-Meunier',
-            'pseudo_adh' => 'ubertrand',
-            'pays_adh' => 'Antarctique',
-            'tel_adh' => '0439153432',
-            'activite_adh' => true,
-            'id_statut' => 9,
-            'date_crea_adh' => '2020-06-10',
-            'pref_lang' => 'en_US',
-            'fingerprint' => 'FAKER' . $this->seed,
+        $data = $this->dataAdherentOne() + [
             'info_field_' . $adf->getId() . '_1' => 'My value (:'
         ];
         $this->createMember($data);
@@ -376,7 +351,7 @@ Au milieu
         );
 
         $this->assertSame(
-            'name: DURAND René login: arthur.hamon birthdate: 1937-12-26 dynlabel: Dynamic text field dynvalue: ' .
+            'name: DURAND René login: arthur.hamon' .  $this->seed . ' birthdate: ' . $data['ddn_adh'] . ' dynlabel: Dynamic text field dynvalue: ' .
             'My value (: ' .
             '- enddate: ' . $this->contrib->end_date . ' amount: 92 (ninety-two) dynlabel: Dynamic date field ' .
             'dynvalue: 2020-12-03',
@@ -396,27 +371,6 @@ Au milieu
         $this->assertTrue(isset($legend['contribution']['patterns']['label_dynfield_' . $cdf->getId() . '_contrib']));
     }
 
-    /**
-     * Create member from data
-     *
-     * @param array $data Data to use to create member
-     *
-     * @return Adherent
-     */
-    public function createMember(array $data)
-    {
-        $adh = $this->adh;
-        $check = $adh->check($data, [], []);
-        if (is_array($check)) {
-            var_dump($check);
-        }
-        $this->assertTrue($check);
-
-        $store = $adh->store();
-        $this->assertTrue($store);
-        return $adh;
-    }
-
     /**
      * Create test contribution in database
      *

diff --git a/tests/Galette/Entity/tests/units/Social.php b/tests/Galette/Entity/tests/units/Social.php
index a65fdd6ba1cb2904ee87c64964c1f64ec3f94dd9..0664d8404cacb4f81d63b79c7df3c526d2062234 100644 (file)
--- a/tests/Galette/Entity/tests/units/Social.php
+++ b/tests/Galette/Entity/tests/units/Social.php
@@ -73,8 +73,6 @@ class Social extends GaletteTestCase
         $delete = $this->zdb->delete(\Galette\Entity\Adherent::TABLE);
         $delete->where(['fingerprint' => 'FAKER' . $this->seed]);
         $this->zdb->execute($delete);
-
-        $this->cleanHistory();
     }
 
     /**

diff --git a/tests/Galette/Entity/tests/units/Transaction.php b/tests/Galette/Entity/tests/units/Transaction.php
index 5e07e902a17c5a4b5c4958f836114f2207d311ec..19be6e393a72fc988e78360962e84f3ddb08a23f 100644 (file)
--- a/tests/Galette/Entity/tests/units/Transaction.php
+++ b/tests/Galette/Entity/tests/units/Transaction.php
@@ -87,8 +87,6 @@ class Transaction extends GaletteTestCase
         $delete = $this->zdb->delete(\Galette\Entity\Adherent::TABLE);
         $delete->where(['fingerprint' => 'FAKER' . $this->seed]);
         $this->zdb->execute($delete);
-
-        $this->cleanHistory();
     }
 
     /**

diff --git a/tests/Galette/Util/tests/units/Password.php b/tests/Galette/Util/tests/units/Password.php
index b2be6741f19ce4d158b76d1eb8f6519608d05e5d..9447b076a0ce253fb28e0c3a8181ea4154f3c7df 100644 (file)
--- a/tests/Galette/Util/tests/units/Password.php
+++ b/tests/Galette/Util/tests/units/Password.php
@@ -252,7 +252,7 @@ class Password extends TestCase
         );
         $login = new \Galette\Core\Login($this->zdb, $i18n);
         $history = new \Galette\Core\History($this->zdb, $login, $this->preferences);
-        include_once GALETTE_ROOT . 'includes/fields_defs/members_fields.php';
+        include GALETTE_ROOT . 'includes/fields_defs/members_fields.php';
         $members_fields = $members_fields;
 
         $adh = new \Galette\Entity\Adherent($this->zdb);

diff --git a/tests/GaletteTestCase.php b/tests/GaletteTestCase.php
index b7c5593e990f7427ed8174da83bd5d42b7b49c9a..ce2b062f5b93b2a23ee1f80b78406a0f7dbefd1b 100644 (file)
--- a/tests/GaletteTestCase.php
+++ b/tests/GaletteTestCase.php
@@ -150,6 +150,7 @@ abstract class GaletteTestCase extends TestCase
         if (TYPE_DB === 'mysql') {
             $this->assertSame($this->expected_mysql_warnings, $this->zdb->getWarnings());
         }
+        $this->cleanHistory();
     }
 
     /**
@@ -190,8 +191,8 @@ abstract class GaletteTestCase extends TestCase
             'ville_adh' => 'Martel',
             'cp_adh' => '39 069',
             'adresse_adh' => '66, boulevard De Oliveira',
-            'email_adh' => 'meunier.josephine@ledoux.com',
-            'login_adh' => 'arthur.hamon',
+            'email_adh' => 'meunier.josephine' .  $this->seed . '@ledoux.com',
+            'login_adh' => 'arthur.hamon' .  $this->seed,
             'mdp_adh' => 'J^B-()f',
             'mdp_adh2' => 'J^B-()f',
             'bool_admin_adh' => false,
@@ -236,8 +237,8 @@ abstract class GaletteTestCase extends TestCase
             'ville_adh' => 'Reynaudnec',
             'cp_adh' => '63077',
             'adresse_adh' => '2, boulevard Legros',
-            'email_adh' => 'phoarau@tele2.fr',
-            'login_adh' => 'nathalie51',
+            'email_adh' => 'phoarau' .  $this->seed . '@tele2.fr',
+            'login_adh' => 'nathalie51' .  $this->seed,
             'mdp_adh' => 'T.u!IbKOi|06',
             'mdp_adh2' => 'T.u!IbKOi|06',
             'bool_admin_adh' => false,
@@ -309,8 +310,8 @@ abstract class GaletteTestCase extends TestCase
             'prenom_adh' => 'René',
             'ville_adh' => 'Martel',
             'adresse_adh' => '66, boulevard De Oliveira',
-            'email_adh' => 'meunier.josephine@ledoux.com',
-            'login_adh' => 'arthur.hamon',
+            'email_adh' => 'meunier.josephine' .  $this->seed . '@ledoux.com',
+            'login_adh' => 'arthur.hamon' .  $this->seed,
             'mdp_adh' => 'J^B-()f',
             'bool_admin_adh' => false,
             'bool_exempt_adh' => false,
@@ -413,8 +414,8 @@ abstract class GaletteTestCase extends TestCase
             'ville_adh' => 'Reynaudnec',
             'cp_adh' => '63077',
             'adresse_adh' => '2, boulevard Legros',
-            'email_adh' => 'phoarau@tele2.fr',
-            'login_adh' => 'nathalie51',
+            'email_adh' => 'phoarau' .  $this->seed . '@tele2.fr',
+            'login_adh' => 'nathalie51' .  $this->seed,
             'mdp_adh' => 'T.u!IbKOi|06',
             'bool_admin_adh' => false,
             'bool_exempt_adh' => false,