Avoid count in loops

diff --git a/galette/lib/Galette/Controllers/Crud/MailingsController.php b/galette/lib/Galette/Controllers/Crud/MailingsController.php
index 1f8ad7f7c0a62408997b9d0a5a7b982f245f70c2..a251f42dd54f55765379dae7de2bef4113b7a034 100644 (file)
--- a/galette/lib/Galette/Controllers/Crud/MailingsController.php
+++ b/galette/lib/Galette/Controllers/Crud/MailingsController.php
@@ -336,7 +336,8 @@ class MailingsController extends CrudController
 
                 //handle attachments
                 if (isset($_FILES['files'])) {
-                    for ($i = 0; $i < count($_FILES['files']['name']); $i++) {
+                    $cnt_files = count($_FILES['files']['name']);
+                    for ($i = 0; $i < $cnt_files; $i++) {
                         if ($_FILES['files']['error'][$i] === UPLOAD_ERR_OK) {
                             if ($_FILES['files']['tmp_name'][$i] != '') {
                                 if (is_uploaded_file($_FILES['files']['tmp_name'][$i])) {

diff --git a/galette/lib/Galette/Controllers/PluginsController.php b/galette/lib/Galette/Controllers/PluginsController.php
index 16c5ced388fedd14a929b0f6ac52fdfaf43b1b08..a965c2518a67976eb5e7a703eaed57760332dcc5 100644 (file)
--- a/galette/lib/Galette/Controllers/PluginsController.php
+++ b/galette/lib/Galette/Controllers/PluginsController.php
@@ -305,7 +305,8 @@ class PluginsController extends AbstractController
 
                 $sql_query = split_sql_file($sql_query, ';');
 
-                for ($i = 0; $i < sizeof($sql_query); $i++) {
+                $sql_size = sizeof($sql_query);
+                for ($i = 0; $i < $sql_size; $i++) {
                     $query = trim($sql_query[$i]);
                     if ($query != '' && $query[0] != '-') {
                         //some output infos

diff --git a/galette/lib/Galette/Core/Install.php b/galette/lib/Galette/Core/Install.php
index 13ead0ef0e09c149b8a8d644bf6d98251b5f3a99..03231537934eb381ec6c9b6768d274ad05e8bdf1 100644 (file)
--- a/galette/lib/Galette/Core/Install.php
+++ b/galette/lib/Galette/Core/Install.php
@@ -724,7 +724,8 @@ class Install
 
         $zdb->connection->beginTransaction();
 
-        for ($i = 0; $i < sizeof($sql_query); $i++) {
+        $sql_size = sizeof($sql_query);
+        for ($i = 0; $i < $sql_size; $i++) {
             $query = trim($sql_query[$i]);
             if ($query != '' && $query[0] != '-') {
                 //some output infos

diff --git a/galette/lib/Galette/DynamicFields/DynamicField.php b/galette/lib/Galette/DynamicFields/DynamicField.php
index ce64c77ec49bf20fc6249c70c141332a85fdb51c..bb080e8d95ed1313c70fc413159b6099d76d893a 100644 (file)
--- a/galette/lib/Galette/DynamicFields/DynamicField.php
+++ b/galette/lib/Galette/DynamicFields/DynamicField.php
@@ -786,7 +786,8 @@ abstract class DynamicField
                     );
                     $stmt = $this->zdb->sql->prepareStatementForSqlObject($insert);
 
-                    for ($i = 0; $i < count($this->values); $i++) {
+                    $cnt_values = count($this->values);
+                    for ($i = 0; $i < $cnt_values; $i++) {
                         $stmt->execute(
                             array(
                                 'id'    => $i,

diff --git a/galette/lib/Galette/IO/CsvIn.php b/galette/lib/Galette/IO/CsvIn.php
index 090cc7bd0b6cd2a8058c36651c9ac17cc5befffd..412d3f8aff37d30eda3ac5206dc6bd1e4968dbd6 100644 (file)
--- a/galette/lib/Galette/IO/CsvIn.php
+++ b/galette/lib/Galette/IO/CsvIn.php
@@ -424,7 +424,8 @@ class CsvIn extends Csv implements FileInterface
                 $errors = $member->getErrors();
                 if (count($errors) > $errcnt) {
                     $lcnt = ($errcnt > 0 ? $errcnt - 1 : 0);
-                    for ($i = $lcnt; $i < count($errors); ++$i) {
+                    $cnt_err = count($errors);
+                    for ($i = $lcnt; $i < $cnt_err; ++$i) {
                         $this->addError($errors[$i]);
                     }
                     return false;