]> git.agnieray.net Git - galette.git/commitdiff
Merge member address continuation into address and remove it
authorJohan Cwiklinski <johan@x-tnd.be>
Sun, 28 Nov 2021 09:56:44 +0000 (10:56 +0100)
committerJohan Cwiklinski <johan@x-tnd.be>
Sun, 28 Nov 2021 15:55:19 +0000 (16:55 +0100)
16 files changed:
galette/includes/fields_defs/members_fields.php
galette/install/scripts/mysql.sql
galette/install/scripts/pgsql.sql
galette/install/scripts/upgrade-to-0.96-mysql.sql
galette/install/scripts/upgrade-to-0.96-pgsql.sql
galette/lib/Galette/Core/Preferences.php
galette/lib/Galette/Entity/Adherent.php
galette/lib/Galette/Entity/FieldsConfig.php
galette/lib/Galette/Entity/ListsConfig.php
galette/lib/Galette/Features/Replacements.php
galette/lib/Galette/IO/PdfMembersLabels.php
galette/lib/Galette/Repository/Members.php
galette/templates/default/forms_types.tpl
galette/templates/default/forms_types/address.tpl
tests/Galette/Entity/tests/units/FieldsConfig.php
tests/GaletteTestCase.php

index 4a797ef4ad9aad63414cb9f32ac89725c1c72bdb..fab78ab1d8c880335d6d552ce8bb09577e9969aa 100644 (file)
@@ -7,7 +7,7 @@
  *
  * PHP version 5
  *
- * Copyright © 2012-2014 The Galette Team
+ * Copyright © 2012-2021 The Galette Team
  *
  * This file is part of Galette (http://galette.tuxfamily.org).
  *
@@ -124,15 +124,6 @@ $members_fields = array(
         'position' => 11,
         'category' => FieldsCategories::ADH_CATEGORY_CONTACT
     ),
-    /** TODO remove second address... */
-    'adresse2_adh' => array(
-        'label'    => _T("Address (continuation)"),
-        'propname' => 'address_continuation',
-        'required' => false,
-        'visible'  => FieldsConfig::USER_WRITE,
-        'position' => 12,
-        'category' => FieldsCategories::ADH_CATEGORY_CONTACT
-    ),
     'cp_adh' => array(
         'label'    => _T("Zip Code:"),
         'propname' => 'zipcode',
index 4461b07bc741450c03b60c04a887e86ca8ec9c8f..17d87102c551dc65b09dd94432b9d2f07a663b36 100644 (file)
@@ -15,7 +15,6 @@ CREATE TABLE galette_adherents (
   ddn_adh date default '1901-01-01',
   sexe_adh tinyint(1) NOT NULL default '0',
   adresse_adh text NOT NULL,
-  adresse2_adh varchar(150) default NULL, -- TODO: remove
   cp_adh varchar(10) NOT NULL default '',
   ville_adh varchar(200) NOT NULL default '',
   pays_adh varchar(200) default NULL,
index fc5f5d93626c5144462ca0d584d09c3fd59e13e1..d9d6cafdab2274aa6c6db07a314cd112414137b3 100644 (file)
@@ -202,7 +202,6 @@ CREATE TABLE galette_adherents (
     ddn_adh date DEFAULT '19010101',
     sexe_adh smallint DEFAULT '0' NOT NULL,
     adresse_adh text DEFAULT '' NOT NULL,
-    adresse2_adh character varying(150) DEFAULT NULL, -- TODO: remove
     cp_adh character varying(10) DEFAULT '' NOT NULL,
     ville_adh character varying(200) DEFAULT '' NOT NULL,
     pays_adh character varying(200) DEFAULT NULL,
index 338815c8053c6f6441d091ac5c1acd964edfc8db..cfa8317337e2d76566516dba3bfb30d1f0181687 100644 (file)
@@ -29,13 +29,21 @@ INSERT INTO galette_socials (id_adh, type, url) SELECT id_adh, 'website', url_ad
 INSERT INTO galette_socials (id_adh, type, url) SELECT id_adh, 'icq', icq_adh FROM galette_adherents WHERE icq_adh != '';
 INSERT INTO galette_socials (id_adh, type, url) SELECT id_adh, 'msn', msn_adh FROM galette_adherents WHERE msn_adh != '';
 INSERT INTO galette_socials (id_adh, type, url) SELECT id_adh, 'jabber', jabber_adh FROM galette_adherents WHERE jabber_adh != '';
+
+-- drop adresse2_adh field
+UPDATE galette_adherents SET adresse2_adh = NULL WHERE adresse2_adh = '';
+UPDATE galette_adherents SET adresse_adh = CONCAT_WS("\n", adresse_adh, adresse2_adh);
+
 -- cleanup members table
 ALTER TABLE galette_adherents DROP column url_adh;
 ALTER TABLE galette_adherents DROP column icq_adh;
 ALTER TABLE galette_adherents DROP column msn_adh;
 ALTER TABLE galette_adherents DROP column jabber_adh;
+ALTER TABLE galette_adherents DROP column adresse2_adh;
+
 -- cleanup fields config
-DELETE FROM galette_fields_config WHERE field_id IN ('url_adh', 'icq_adh', 'msn_adh', 'jabber_adh');
+DELETE FROM galette_fields_config WHERE field_id IN ('url_adh', 'icq_adh', 'msn_adh', 'jabber_adh', 'adresse2_adh');
+
 
 -- add num_adh column
 ALTER TABLE galette_adherents ADD COLUMN num_adh varchar(255) DEFAULT NULL;
index 4bf1b953c07d9144f802789c31320629a1e53e0c..fc64a3eeca4a93e641a63cb2466d57d6b59e22c0 100644 (file)
@@ -37,13 +37,20 @@ INSERT INTO galette_socials (id_adh, type, url) SELECT id_adh, 'website', url_ad
 INSERT INTO galette_socials (id_adh, type, url) SELECT id_adh, 'icq', icq_adh FROM galette_adherents WHERE icq_adh != '';
 INSERT INTO galette_socials (id_adh, type, url) SELECT id_adh, 'msn', msn_adh FROM galette_adherents WHERE msn_adh != '';
 INSERT INTO galette_socials (id_adh, type, url) SELECT id_adh, 'jabber', jabber_adh FROM galette_adherents WHERE jabber_adh != '';
+
+-- drop adresse2_adh field
+UPDATE galette_adherents SET adresse2_adh = NULL WHERE adresse2_adh = '';
+UPDATE galette_adherents SET adresse_adh = CONCAT_WS('\n', adresse_adh, adresse2_adh);
+
 -- cleanup members table
 ALTER TABLE galette_adherents DROP column url_adh;
 ALTER TABLE galette_adherents DROP column icq_adh;
 ALTER TABLE galette_adherents DROP column msn_adh;
 ALTER TABLE galette_adherents DROP column jabber_adh;
+ALTER TABLE galette_adherents DROP column adresse2_adh;
+
 -- cleanup fields config table
-DELETE FROM galette_fields_config WHERE field_id IN ('url_adh', 'icq_adh', 'msn_adh', 'jabber_adh');
+DELETE FROM galette_fields_config WHERE field_id IN ('url_adh', 'icq_adh', 'msn_adh', 'jabber_adh', 'adresse2_adh');
 
 -- add num_adh column
 ALTER TABLE galette_adherents ADD COLUMN num_adh character varying (255) DEFAULT NULL;
index 111128fba8130b8f66b6dcba9a6504e243e60f38..946f9f4bc0115e1d33bab1767966190dc09f0653 100644 (file)
@@ -882,9 +882,7 @@ class Preferences
                 _T("%name association's %status")
             ) . "\n";
             $_address = $adh->address;
-            if ($adh->address_continuation && $adh->address_continuation != '') {
-                $_address .= "\n" . $adh->address_continuation;
-            }
+
             $replacements = array(
                 $adh->sfullname . "\n",
                 $_complement,
index 16d945384dc71b1ef77dee32caad6ea4450fe777..ca74408be72aeb3be9755cccc1d774e8f5eed7a0 100644 (file)
@@ -70,8 +70,8 @@ use Galette\Features\Dynamics;
  * @property string $name
  * @property string $surname
  * @property string $nickname
- * @property string $birthdate Localized birth date
- * @property string $rbirthdate Raw birth date
+ * @property string $birthdate Localized birthdate
+ * @property string $rbirthdate Raw birthdate
  * @property string $birth_place
  * @property integer $gender
  * @property string $sgender Gender label
@@ -80,7 +80,6 @@ use Galette\Features\Dynamics;
  * @property integer $status
  * @property string $sstatus Status label
  * @property string $address
- * @property string $address_continuation
  * @property string $zipcode
  * @property string $town
  * @property string $country
@@ -113,7 +112,7 @@ use Galette\Features\Dynamics;
  * @property string $sactive yes/no
  * @property string $sfullname
  * @property string $sname
- * @property string $saddress Concatened address and continuation
+ * @property string $saddress
  * @property string $contribstatus State of member contributions
  * @property string $days_remaining
  * @property-read integer $parent_id
@@ -156,7 +155,6 @@ class Adherent
     private $_status;
     //Contact information
     private $_address;
-    private $_address_continuation; /** TODO: remove */
     private $_zipcode;
     private $_town;
     private $_country;
@@ -208,7 +206,6 @@ class Adherent
 
     private $parent_fields = [
         'adresse_adh',
-        'adresse2_adh',
         'cp_adh',
         'ville_adh',
         'email_adh'
@@ -383,8 +380,6 @@ class Adherent
         $this->_status = (int)$r->id_statut;
         //Contact information
         $this->_address = $r->adresse_adh;
-        /** TODO: remove and merge with address */
-        $this->_address_continuation = $r->adresse2_adh;
         $this->_zipcode = $r->cp_adh;
         $this->_town = $r->ville_adh;
         $this->_country = $r->pays_adh;
@@ -1730,27 +1725,19 @@ class Adherent
                 case 'sstatus':
                     $status = new Status($this->zdb);
                     return $status->getLabel($this->_status);
-                    break;
                 case 'sfullname':
                     return $this->getNameWithCase(
                         $this->_name,
                         $this->_surname,
                         (isset($this->_title) ? $this->title : false)
                     );
-                    break;
                 case 'saddress':
                     $address = $this->_address;
-                    if ($this->_address_continuation !== '' && $this->_address_continuation !== null) {
-                        $address .= "\n" . $this->_address_continuation;
-                    }
                     return $address;
-                    break;
                 case 'sname':
                     return $this->getNameWithCase($this->_name, $this->_surname);
-                    break;
                 case 'rbirthdate':
                     return $this->_birthdate;
-                    break;
                 case 'sgender':
                     switch ($this->gender) {
                         case self::MAN:
@@ -1760,10 +1747,8 @@ class Adherent
                         default:
                             return _T('Unspecified');
                     }
-                    break;
                 case 'contribstatus':
                     return $this->getDues();
-                    break;
             }
         }
 
@@ -1787,11 +1772,8 @@ class Adherent
                 } else {
                     return null;
                 }
-                break;
             case 'address':
-            case 'address_continuation':
                 return $this->$rname ?? '';
-                break;
             case 'birthdate':
             case 'creation_date':
             case 'modification_date':
@@ -1813,7 +1795,6 @@ class Adherent
                 break;
             case 'parent_id':
                 return ($this->_parent instanceof Adherent) ? (int)$this->_parent->id : (int)$this->_parent;
-                break;
             default:
                 if (!property_exists($this, $rname)) {
                     Analog::log(
@@ -1824,7 +1805,6 @@ class Adherent
                 } else {
                     return $this->$rname;
                 }
-                break;
         }
     }
 
@@ -1863,24 +1843,6 @@ class Adherent
         return $address ?? '';
     }
 
-    /**
-     * Get member address continuation.
-     * If member does not have an address, but is attached to another member, we'll take information from its parent.
-     *
-     * @return string
-     */
-    public function getAddressContinuation(): string
-    {
-        $address = $this->_address;
-        $address_continuation = $this->_address_continuation;
-        if (empty($address) && $this->hasParent()) {
-            $this->loadParent();
-            $address_continuation = $this->parent->address_continuation;
-        }
-
-        return $address_continuation ?? '';
-    }
-
     /**
      * Get member zipcode.
      * If member does not have an address, but is attached to another member, we'll take information from its parent.
index 60434a581275753367cc7170533f27b9684de03f..f8defda5ac01e6eae027f530c14c72538c4e4ff2 100644 (file)
@@ -133,8 +133,7 @@ class FieldsConfig
         'mdp_adh',
         'titre_adh',
         'sexe_adh',
-        'prenom_adh',
-        'adresse2_adh'
+        'prenom_adh'
     );
 
     /**
index 256b4bafe6ae6edf1691965ded80ab27bffd1b74..4bae2be37e742262043a3766ceb12e1943c51639 100644 (file)
@@ -68,7 +68,6 @@ class ListsConfig extends FieldsConfig
      */
     private $non_list_elements = array(
         'mdp_adh',
-        'adresse2_adh',
         'info_adh',
         'info_public_adh',
         'nom_adh',
index b8d89da11572c0acf4724606beb4ab8ac3c10feb..7c4086599d6eb3f257ba1f71f7adb32428ea2d3f 100644 (file)
@@ -598,9 +598,6 @@ trait Replacements
         global $login;
 
         $address = $member->getAddress();
-        if ($member->getAddressContinuation() !== '') {
-            $address .= '<br/>' . $member->getAddressContinuation();
-        }
 
         if ($member->isMan()) {
             $gender = _T("Man");
index fe78931d73e96266232c74415afd489dd97b5571..f43a08d577073a4b718edf00218b316579ef04ab 100644 (file)
@@ -166,28 +166,16 @@ class PdfMembersLabels extends Pdf
             $this->SetFont(self::FONT, '', $this->preferences->pref_etiq_corps);
             $this->SetXY($x, $y + $this->line_h);
 
-            //calculte font size to display address and address continuation
+            //calculte font size to display address
             $max_text_size = $this->preferences->pref_etiq_hsize;
-            $text = mb_strlen($member->address) > mb_strlen($member->address_continuation) ?
-                $member->address : $member->address_continuation;
             $this->fixSize(
-                $text,
+                $member->address,
                 $max_text_size,
                 $this->preferences->pref_etiq_corps
             );
 
             $this->Cell($this->lw, $this->line_h, $member->address, 0, 0, 'L', 0);
-            // Print second line of address
-            $this->SetXY($x, $y + $this->line_h * 2);
-            $this->Cell(
-                $this->lw,
-                $this->line_h,
-                $member->address_continuation,
-                0,
-                0,
-                'L',
-                0
-            );
+
             // Print zip code and town
             $this->SetFont(self::FONT, 'B', $this->preferences->pref_etiq_corps);
             $text = $member->zipcode . ' - ' . $member->town;
index 09cb8cdd07fcfd977b18bb5907ef6ebbf9dec56c..8b70514f075eada12b438215896659c7115fe794 100644 (file)
@@ -1044,8 +1044,6 @@ class Members
                             '(' .
                             'LOWER(adresse_adh) LIKE ' . $token
                             . ' OR ' .
-                            'LOWER(adresse2_adh) LIKE ' . $token
-                            . ' OR ' .
                             'cp_adh LIKE ' . $token
                             . ' OR ' .
                             'LOWER(ville_adh) LIKE ' . $token
index 3d70a8dd8ddeea53563e794f4faf938699316af6..de6f664f4a83ad783cd573d47cb67d84fcaac5ec 100644 (file)
                     {include file="forms_types/picture.tpl"}
                 {/if}
                 {foreach item=entry from=$fieldset->elements}
-                    {if $entry->field_id neq 'adresse2_adh'}
-                        {assign var="template" value="text.tpl"}
-                        {assign var="title" value=null}
-                        {assign var="tip" value=null}
-                        {assign var="size" value=null}
-                        {assign var="propname" value=$entry->propname}
-                        {assign var="value" value=null}
-                        {assign var="checked" value=null}
-                        {assign var="example" value=null}
+                    {assign var="template" value="text.tpl"}
+                    {assign var="title" value=null}
+                    {assign var="tip" value=null}
+                    {assign var="size" value=null}
+                    {assign var="propname" value=$entry->propname}
+                    {assign var="value" value=null}
+                    {assign var="checked" value=null}
+                    {assign var="example" value=null}
 
-                        {if $entry->type eq constant('Galette\Entity\FieldsConfig::TYPE_BOOL')}
-                            {assign var="template" value="checkbox.tpl"}
-                            {assign var="value" value="1"}
-                        {/if}
-                        {if $entry->field_id eq 'titre_adh'}
-                            {assign var="template" value="titles.tpl"}
-                            {assign var="value" value=$member->title}
-                        {/if}
-                        {if $entry->field_id eq 'pref_lang'}
-                            {assign var="template" value="lang.tpl"}
-                        {/if}
-                        {if $entry->field_id eq 'sexe_adh'}
-                            {assign var="template" value="gender.tpl"}
-                        {/if}
-                        {if $entry->field_id eq 'societe_adh'}
-                            {assign var="template" value="company.tpl"}
-                        {/if}
-                        {if $entry->field_id|strpos:'date_' === 0 or $entry->field_id eq 'ddn_adh'}
-                            {assign var="template" value="date.tpl"}
-                        {/if}
-                        {if $entry->field_id eq 'adresse_adh'}
-                            {assign var="template" value="address.tpl"}
-                        {/if}
-                        {if $entry->field_id eq 'mdp_adh'}
-                            {if !$self_adh}
-                                {assign var="template" value="password.tpl"}
-                            {else}
-                                {assign var="template" value="captcha.tpl"}
-                            {/if}
+                    {if $entry->type eq constant('Galette\Entity\FieldsConfig::TYPE_BOOL')}
+                        {assign var="template" value="checkbox.tpl"}
+                        {assign var="value" value="1"}
+                    {/if}
+                    {if $entry->field_id eq 'titre_adh'}
+                        {assign var="template" value="titles.tpl"}
+                        {assign var="value" value=$member->title}
+                    {/if}
+                    {if $entry->field_id eq 'pref_lang'}
+                        {assign var="template" value="lang.tpl"}
+                    {/if}
+                    {if $entry->field_id eq 'sexe_adh'}
+                        {assign var="template" value="gender.tpl"}
+                    {/if}
+                    {if $entry->field_id eq 'societe_adh'}
+                        {assign var="template" value="company.tpl"}
+                    {/if}
+                    {if $entry->field_id|strpos:'date_' === 0 or $entry->field_id eq 'ddn_adh'}
+                        {assign var="template" value="date.tpl"}
+                    {/if}
+                    {if $entry->field_id eq 'adresse_adh'}
+                        {assign var="template" value="address.tpl"}
+                    {/if}
+                    {if $entry->field_id eq 'mdp_adh'}
+                        {if !$self_adh}
+                            {assign var="template" value="password.tpl"}
+                        {else}
+                            {assign var="template" value="captcha.tpl"}
                         {/if}
-                        {if $entry->field_id eq 'info_adh'
-                            or $entry->field_id eq 'info_public_adh'}
-                            {assign var="template" value="textarea.tpl"}
-                            {if $entry->field_id eq 'info_adh'}
-                                {assign var="example" value={_T string="This comment is only displayed for admins and staff members."}}
-                            {else}
-                                {if $login->isAdmin() or $login->isStaff()}
-                                    {assign var="example" value={_T string="This comment is reserved to the member."}}
-                                {/if}
+                    {/if}
+                    {if $entry->field_id eq 'info_adh'
+                        or $entry->field_id eq 'info_public_adh'}
+                        {assign var="template" value="textarea.tpl"}
+                        {if $entry->field_id eq 'info_adh'}
+                            {assign var="example" value={_T string="This comment is only displayed for admins and staff members."}}
+                        {else}
+                            {if $login->isAdmin() or $login->isStaff()}
+                                {assign var="example" value={_T string="This comment is reserved to the member."}}
                             {/if}
                         {/if}
-                        {if $entry->field_id eq 'activite_adh'}
-                            {assign var="template" value="account.tpl"}
-                        {/if}
-                        {if $entry->field_id eq 'id_statut'}
-                            {assign var="template" value="status.tpl"}
-                        {/if}
-
-                        {if $entry->field_id eq 'gpgid'}
-                            {assign var="size" value="8"}
-                        {/if}
-                        {if $entry->field_id eq 'email_adh'}
-                            {assign var="size" value="30"}
-                        {/if}
-                        {if $entry->field_id eq 'fingerprint'}
-                            {assign var="size" value="40"}
-                        {/if}
-                        {if $entry->field_id eq 'bool_display_info'}
-                            {assign var="title" value={_T string="Do member want to appear publically?"}}
-                            {assign var="tip" value={_T string="If you check this box (and if you are up to date with your contributions), your full name and other information will be publically visible on the members list.<br/>If you've uploaded a photo, it will be displayed on the trombinoscope page.<br/>Note that administrators can disabled public pages, this setting will have no effect in that case."}}
-                            {assign var="checked" value=$member->appearsInMembersList()}
-                        {/if}
-                        {if $entry->field_id eq 'login_adh'}
-                            {assign var="example" value={_T string="(at least %i characters)" pattern="/%i/" replace=2}}
-                        {/if}
+                    {/if}
+                    {if $entry->field_id eq 'activite_adh'}
+                        {assign var="template" value="account.tpl"}
+                    {/if}
+                    {if $entry->field_id eq 'id_statut'}
+                        {assign var="template" value="status.tpl"}
+                    {/if}
 
-                        {if $entry->field_id eq 'bool_admin_adh'}
-                            {assign var="checked" value=$member->isAdmin()}
-                        {/if}
-                        {if $entry->field_id eq 'bool_exempt_adh'}
-                            {assign var="checked" value=$member->isDueFree()}
-                        {/if}
-                        {if $entry->field_id eq 'parent_id'}
-                            {assign var="value" value=$member->parent->id}
-                        {/if}
-                        {if $entry->field_id eq 'activite_adh'}
-                            {assign var="value" value=$member->isActive()}
-                        {/if}
+                    {if $entry->field_id eq 'gpgid'}
+                        {assign var="size" value="8"}
+                    {/if}
+                    {if $entry->field_id eq 'email_adh'}
+                        {assign var="size" value="30"}
+                    {/if}
+                    {if $entry->field_id eq 'fingerprint'}
+                        {assign var="size" value="40"}
+                    {/if}
+                    {if $entry->field_id eq 'bool_display_info'}
+                        {assign var="title" value={_T string="Do member want to appear publically?"}}
+                        {assign var="tip" value={_T string="If you check this box (and if you are up to date with your contributions), your full name and other information will be publically visible on the members list.<br/>If you've uploaded a photo, it will be displayed on the trombinoscope page.<br/>Note that administrators can disabled public pages, this setting will have no effect in that case."}}
+                        {assign var="checked" value=$member->appearsInMembersList()}
+                    {/if}
+                    {if $entry->field_id eq 'login_adh'}
+                        {assign var="example" value={_T string="(at least %i characters)" pattern="/%i/" replace=2}}
+                    {/if}
 
-                        {* If value has not been set, take the generic value *}
-                        {if !$value and $propname != 'password'}
-                            {assign var="value" value=$member->$propname}
-                        {/if}
+                    {if $entry->field_id eq 'bool_admin_adh'}
+                        {assign var="checked" value=$member->isAdmin()}
+                    {/if}
+                    {if $entry->field_id eq 'bool_exempt_adh'}
+                        {assign var="checked" value=$member->isDueFree()}
+                    {/if}
+                    {if $entry->field_id eq 'parent_id'}
+                        {assign var="value" value=$member->parent->id}
+                    {/if}
+                    {if $entry->field_id eq 'activite_adh'}
+                        {assign var="value" value=$member->isActive()}
+                    {/if}
 
-                        {if !isset($masschange)}
-                           {assign var="masschange" value=false}
-                        {/if}
+                    {* If value has not been set, take the generic value *}
+                    {if !$value and $propname != 'password'}
+                        {assign var="value" value=$member->$propname}
+                    {/if}
 
-                        {include
-                            file="forms_types/$template"
-                            name=$entry->field_id
-                            id=$entry->field_id
-                            value=$value
-                            required=$entry->required
-                            readonly=$entry->readonly
-                            disabled=$entry->disabled
-                            label=$entry->label
-                            title=$title
-                            size=$size
-                            tip=$tip
-                            compile_id="input_{$entry->field_id}"
-                            checked=$checked
-                            masschange=$masschange
-                        }
+                    {if !isset($masschange)}
+                       {assign var="masschange" value=false}
                     {/if}
+
+                    {include
+                        file="forms_types/$template"
+                        name=$entry->field_id
+                        id=$entry->field_id
+                        value=$value
+                        required=$entry->required
+                        readonly=$entry->readonly
+                        disabled=$entry->disabled
+                        label=$entry->label
+                        title=$title
+                        size=$size
+                        tip=$tip
+                        compile_id="input_{$entry->field_id}"
+                        checked=$checked
+                        masschange=$masschange
+                    }
+
                 {/foreach}
                 {if isset($groups) and $groups|@count != 0 and $fieldset@last and (!isset($masschange) or $masschange == false)}
                     {include file="forms_types/groups.tpl"}
index 8d24ff7e592d7088c96cd1f0a50f209632ade26e..db2cb0e2c1f04fbd5e31c58e360c04843aebf51d 100644 (file)
     notag=true
     elt_class="large"
 }
-{if isset($fieldset->elements['adresse2_adh'])}
-<br/>
-{assign var="address2" value=$fieldset->elements['adresse2_adh']}
-{include
-    file="forms_types/text.tpl"
-    name=$address2->field_id
-    id=$address2->field_id
-    value=$member->address_continuation|escape
-    required=$address2->required
-    disabled=$address2->disabled
-    label=$address2->label
-    notag=true
-    elt_class="large"
-}
-{/if}
 </p>
index 8313f4574684680d9eb94e7b9930a863dac1ba70..2b0c2b4d362c0bffd3f0b98a089924e9f2c01ba7 100644 (file)
@@ -186,7 +186,7 @@ class FieldsConfig extends atoum
         $this->array($categorized[\Galette\Entity\FieldsCategories::ADH_CATEGORY_GALETTE])
             ->hasSize(11);
         $this->array($categorized[\Galette\Entity\FieldsCategories::ADH_CATEGORY_CONTACT])
-            ->hasSize(11);
+            ->hasSize(10);
     }
 
     /**
@@ -248,7 +248,7 @@ class FieldsConfig extends atoum
         $fields = $fields_config->getCategorizedFields();
 
         //town
-        $town = &$fields[\Galette\Entity\FieldsCategories::ADH_CATEGORY_CONTACT][3];
+        $town = &$fields[\Galette\Entity\FieldsCategories::ADH_CATEGORY_CONTACT][2];
         $this->boolean($town['required'])->isTrue();
         $this->integer($town['visible'])->isIdenticalTo(\Galette\Entity\FieldsConfig::USER_WRITE);
 
@@ -256,9 +256,9 @@ class FieldsConfig extends atoum
         $town['visible'] = \Galette\Entity\FieldsConfig::NOBODY;
 
         //gsm
-        $gsm = $fields[\Galette\Entity\FieldsCategories::ADH_CATEGORY_CONTACT][6];
+        $gsm = $fields[\Galette\Entity\FieldsCategories::ADH_CATEGORY_CONTACT][5];
         $gsm['position'] = count($fields[1]);
-        unset($fields[\Galette\Entity\FieldsCategories::ADH_CATEGORY_CONTACT][6]);
+        unset($fields[\Galette\Entity\FieldsCategories::ADH_CATEGORY_CONTACT][5]);
         $gsm['category'] = \Galette\Entity\FieldsCategories::ADH_CATEGORY_IDENTITY;
         $fields[\Galette\Entity\FieldsCategories::ADH_CATEGORY_IDENTITY][] = $gsm;
 
@@ -267,7 +267,7 @@ class FieldsConfig extends atoum
         $fields_config->load();
         $fields = $fields_config->getCategorizedFields();
 
-        $town = $fields[\Galette\Entity\FieldsCategories::ADH_CATEGORY_CONTACT][3];
+        $town = $fields[\Galette\Entity\FieldsCategories::ADH_CATEGORY_CONTACT][2];
         $this->boolean($town['required'])->isFalse();
         $this->integer($town['visible'])->isIdenticalTo(\Galette\Entity\FieldsConfig::NOBODY);
 
@@ -454,7 +454,7 @@ class FieldsConfig extends atoum
 
         $this->object($elements['fieldsets'][1])->isInstanceOf('\stdClass');
         $this->integer($elements['fieldsets'][1]->id)->isIdenticalTo(3);
-        $this->array($elements['fieldsets'][1]->elements)->hasSize(9);
+        $this->array($elements['fieldsets'][1]->elements)->hasSize(8);
 
         $this->object($elements['fieldsets'][2])->isInstanceOf('\stdClass');
         $this->integer($elements['fieldsets'][2]->id)->isIdenticalTo(2);
@@ -485,7 +485,7 @@ class FieldsConfig extends atoum
 
         $this->object($elements['fieldsets'][1])->isInstanceOf('\stdClass');
         $this->integer($elements['fieldsets'][1]->id)->isIdenticalTo(3);
-        $this->array($elements['fieldsets'][1]->elements)->hasSize(9);
+        $this->array($elements['fieldsets'][1]->elements)->hasSize(8);
 
         $mail = $elements['fieldsets'][1]->elements['email_adh'];
         $this->boolean($mail->required)->isFalse(); //email is not required per default
@@ -523,7 +523,7 @@ class FieldsConfig extends atoum
 
         $this->object($elements['fieldsets'][1])->isInstanceOf('\stdClass');
         $this->integer($elements['fieldsets'][1]->id)->isIdenticalTo(3);
-        $this->array($elements['fieldsets'][1]->elements)->hasSize(9);
+        $this->array($elements['fieldsets'][1]->elements)->hasSize(8);
 
         $mail = $elements['fieldsets'][1]->elements['email_adh'];
         $this->boolean($mail->required)->isTrue(); //email is required for self subscription
index 052e752d45ca96466807e494eb9f17b86d27996f..f2d9bbf64be2e27c136aba3cb3cf00f9790bca8b 100644 (file)
@@ -391,7 +391,6 @@ abstract class GaletteTestCase extends atoum
         $this->string($adh->sname)->isIdenticalTo('DURAND René');
 
         $this->string($adh->getAddress())->isIdenticalTo($expecteds['adresse_adh']);
-        $this->string($adh->getAddressContinuation())->isEmpty();
         $this->string($adh->getZipcode())->isIdenticalTo($expecteds['cp_adh']);
         $this->string($adh->getTown())->isIdenticalTo($expecteds['ville_adh']);
         $this->string($adh->getCountry())->isIdenticalTo($expecteds['pays_adh']);
@@ -495,7 +494,6 @@ abstract class GaletteTestCase extends atoum
         $this->string($adh->sname)->isIdenticalTo('HOARAU Lucas');
 
         $this->string($adh->getAddress())->isIdenticalTo($expecteds['adresse_adh']);
-        $this->string($adh->getAddressContinuation())->isEmpty();
         $this->string($adh->getZipcode())->isIdenticalTo($expecteds['cp_adh']);
         $this->string($adh->getTown())->isIdenticalTo($expecteds['ville_adh']);
         $this->string($adh->getCountry())->isIdenticalTo($expecteds['pays_adh']);