From f986731e3dbe0fd95e8b9efadc5e2302c1070d21 Mon Sep 17 00:00:00 2001
From: Johan Cwiklinski <johan@x-tnd.be>
Date: Fri, 31 Jul 2020 07:14:32 +0200
Subject: [PATCH] Mass uncheck booleans; closes #1471

---
 galette/lib/Galette/Controllers/Crud/MembersController.php | 7 +++++--
 galette/templates/default/forms_types.tpl                  | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/galette/lib/Galette/Controllers/Crud/MembersController.php b/galette/lib/Galette/Controllers/Crud/MembersController.php
index e30c895b7..a36ad59cb 100644
--- a/galette/lib/Galette/Controllers/Crud/MembersController.php
+++ b/galette/lib/Galette/Controllers/Crud/MembersController.php
@@ -1292,10 +1292,13 @@ class MembersController extends CrudController
             $changes = [];
             foreach ($form_elements['fieldsets'] as $form_element) {
                 foreach ($form_element->elements as $field) {
-                    if (isset($post[$field->field_id]) && isset($post['mass_' . $field->field_id])) {
+                    if (
+                        isset($post['mass_' . $field->field_id])
+                        && (isset($post[$field->field_id]) || $field->type === FieldsConfig::TYPE_BOOL)
+                    ) {
                         $changes[$field->field_id] = [
                             'label' => $field->label,
-                            'value' => $post[$field->field_id]
+                            'value' => $post[$field->field_id] ?? 0
                         ];
                     }
                 }
diff --git a/galette/templates/default/forms_types.tpl b/galette/templates/default/forms_types.tpl
index c08b279fe..262853f0d 100644
--- a/galette/templates/default/forms_types.tpl
+++ b/galette/templates/default/forms_types.tpl
@@ -2,7 +2,7 @@
             <fieldset class="galette_form">
                 <legend>{_T string=$fieldset->label}</legend>
                 <div>
-                {if !$self_adh and $fieldset@first && !isset($masschange)}
+                {if !isset($masschange) && !$self_adh and $fieldset@first}
                     {include file="forms_types/picture.tpl"}
                 {/if}
                 {foreach item=entry from=$fieldset->elements}
-- 
2.39.2