From 994186a94da45a59038b73a30a33430574bed0b4 Mon Sep 17 00:00:00 2001
From: Johan Cwiklinski <johan@x-tnd.be>
Date: Sun, 9 Jul 2023 11:29:34 +0200
Subject: [PATCH] Make member dropdown work without extra code

Changing the linked input type to hidden seems mandatory for selection to work.
---
 galette/templates/default/elements/js/choose_adh.js.twig    | 5 +++++
 galette/templates/default/pages/contribution_form.html.twig | 1 -
 galette/templates/default/pages/member_form.html.twig       | 4 ----
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/galette/templates/default/elements/js/choose_adh.js.twig b/galette/templates/default/elements/js/choose_adh.js.twig
index 427ab7f22..f2600b981 100644
--- a/galette/templates/default/elements/js/choose_adh.js.twig
+++ b/galette/templates/default/elements/js/choose_adh.js.twig
@@ -166,6 +166,11 @@
                 $('.next-results, .prev-results').addClass('disabled');
             },
         });
+
+        var _chosen_id_input = $('{{ js_chosen_id }}_input');
+        if ( typeof(_chosen_id_input) != 'undefined' && _chosen_id_input != null ) {
+            _chosen_id_input.prop('type', 'hidden');
+        }
     }
 
     $(function() {
diff --git a/galette/templates/default/pages/contribution_form.html.twig b/galette/templates/default/pages/contribution_form.html.twig
index 271698238..950b1cd43 100644
--- a/galette/templates/default/pages/contribution_form.html.twig
+++ b/galette/templates/default/pages/contribution_form.html.twig
@@ -246,7 +246,6 @@
 {% block javascripts %}
 <script type="text/javascript">
     {% include "elements/js/choose_adh.js.twig" %}
-    document.getElementById('id_adh_input').type = 'hidden';
 
     $(function() {
 
diff --git a/galette/templates/default/pages/member_form.html.twig b/galette/templates/default/pages/member_form.html.twig
index 7d3280b34..1e700d789 100644
--- a/galette/templates/default/pages/member_form.html.twig
+++ b/galette/templates/default/pages/member_form.html.twig
@@ -192,10 +192,6 @@
 {% block javascripts %}
         <script type="text/javascript">
             {% include "elements/js/choose_adh.js.twig" with {"js_chosen_id": "#parent_id"} %}
-            var _parent_id_input = document.getElementById('parent_id_input');
-            if ( typeof(_parent_id_input) != 'undefined' && _parent_id_input != null ) {
-                document.getElementById('parent_id_input').type = 'hidden';
-            }
 
             $(function() {
                 $('#company_field.nocompany').addClass('displaynone');
-- 
2.39.2