From 4788dca3d6c38c1c63e06bd4db9cd104185c804b Mon Sep 17 00:00:00 2001
From: Johan Cwiklinski <johan@x-tnd.be>
Date: Thu, 6 Jul 2023 06:50:54 +0200
Subject: [PATCH] Prevent empty parent group dropdown; closes #1648

---
 .../lib/Galette/Controllers/Crud/GroupsController.php    | 9 ++++++++-
 galette/templates/default/elements/group.html.twig       | 8 +++-----
 galette/templates/default/pages/groups_list.html.twig    | 2 +-
 3 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/galette/lib/Galette/Controllers/Crud/GroupsController.php b/galette/lib/Galette/Controllers/Crud/GroupsController.php
index 1f939247e..e89e28017 100644
--- a/galette/lib/Galette/Controllers/Crud/GroupsController.php
+++ b/galette/lib/Galette/Controllers/Crud/GroupsController.php
@@ -183,6 +183,13 @@ class GroupsController extends CrudController
             }
         }
 
+        $parent_groups = [];
+        foreach ($groups_list as $parent_group) {
+            if ($group->canSetParentGroup($parent_group)) {
+                $parent_groups[] = $parent_group;
+            }
+        }
+
         //Active tab on page
         $tab = $request->getQueryParams['tab'] ?? 'group_information';
 
@@ -193,7 +200,7 @@ class GroupsController extends CrudController
             array(
                 'page_title'            => _T("Groups"),
                 'groups_root'           => $groups_root,
-                'groups'                => $groups_list,
+                'parent_groups'         => $parent_groups,
                 'group'                 => $group,
                 'tab'                   => $tab
             )
diff --git a/galette/templates/default/elements/group.html.twig b/galette/templates/default/elements/group.html.twig
index ba117a0e2..ca29d021c 100644
--- a/galette/templates/default/elements/group.html.twig
+++ b/galette/templates/default/elements/group.html.twig
@@ -35,13 +35,11 @@
             {% endif %}
             <div class="inline field">
                     <label for="parent_group">{{ _T("Parent group:") }}</label>
-                {% if can_edit %}
+                {% if can_edit and parent_groups|length > 0 %}
                     <select name="parent_group" id="parent_group" class="ui search dropdown nochosen">
                         <option value="">{{ _T("None") }}</option>
-                        {% for g in groups %}
-                            {% if group.canSetParentGroup(g) %}
-                                <option value="{{ g.getId() }}"{% if pgroup is defined and pgroup.getId() == g.getId() %} selected="selected"{% endif %}>{{ g.getIndentName()|raw }}</option>
-                            {% endif %}
+                        {% for g in parent_groups %}
+                            <option value="{{ g.getId() }}"{% if pgroup is defined and pgroup.getId() == g.getId() %} selected="selected"{% endif %}>{{ g.getIndentName()|raw }}</option>
                         {% endfor %}
                     </select>
                 {% else %}
diff --git a/galette/templates/default/pages/groups_list.html.twig b/galette/templates/default/pages/groups_list.html.twig
index cd22e9125..c32d115a8 100644
--- a/galette/templates/default/pages/groups_list.html.twig
+++ b/galette/templates/default/pages/groups_list.html.twig
@@ -52,7 +52,7 @@
         {% endif %}
             </div>
             <div class="thirteen wide column">
-                {% include "elements/group.html.twig" with {"group": group, "groups": groups} %}
+                {% include "elements/group.html.twig" with {"group": group, "parent_groups": parent_groups} %}
             </div>
         </div>
     {% else %}
-- 
2.39.2