From 45200ffd42447e2c4870ec390d4600a9b16e9cf9 Mon Sep 17 00:00:00 2001
From: Johan Cwiklinski <johan@x-tnd.be>
Date: Sun, 9 May 2021 02:00:07 +0200
Subject: [PATCH] Fix web installer

---
 galette/install/steps/db_select_version.php |  8 +++++---
 galette/lib/Galette/Core/Install.php        | 19 ++++++++++---------
 galette/lib/Galette/Core/Preferences.php    |  3 +++
 3 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/galette/install/steps/db_select_version.php b/galette/install/steps/db_select_version.php
index 3a8a05bc4..c753c7fb3 100644
--- a/galette/install/steps/db_select_version.php
+++ b/galette/install/steps/db_select_version.php
@@ -7,7 +7,7 @@
  *
  * PHP version 5
  *
- * Copyright © 2013-2014 The Galette Team
+ * Copyright © 2013-2021 The Galette Team
  *
  * This file is part of Galette (http://galette.tuxfamily.org).
  *
@@ -28,7 +28,7 @@
  * @package   Galette
  *
  * @author    Johan Cwiklinski <johan@x-tnd.be>
- * @copyright 2013-2014 The Galette Team
+ * @copyright 2013-2021 The Galette Team
  * @license   http://www.gnu.org/licenses/gpl-3.0.html GPL License 3.0 or (at your option) any later version
  * @link      http://galette.tuxfamily.org
  * @since     Available since 0.8 - 2013-07-21
@@ -87,6 +87,7 @@ if (count($versions) == 0) {
                     <ul class="leaders">
     <?php
     $is_current = false;
+    $previous = null;
     foreach ($versions as $version) {
         ?>
                     <li>
@@ -115,7 +116,7 @@ if (count($versions) == 0) {
                             </label>
                         </span>
                         <span>
-                        <input type="radio" name="previous_version" value="<?php echo $version; ?>" id="upgrade-<?php echo $version; ?>"<?php if ($is_current) { echo ' checked="checked"'; }; ?> required/>
+                        <input type="radio" name="previous_version" value="<?php echo $previous ?? $version; ?>" id="upgrade-<?php echo $version; ?>"<?php if ($is_current) { echo ' checked="checked"'; }; ?> required/>
                         </span>
         <?php
         if ($is_current) {
@@ -126,6 +127,7 @@ if (count($versions) == 0) {
 
                     </li>
     <?php
+        $previous = $version;
     }
     ?>
                     </ul>
diff --git a/galette/lib/Galette/Core/Install.php b/galette/lib/Galette/Core/Install.php
index da143c87b..bc16b85ae 100644
--- a/galette/lib/Galette/Core/Install.php
+++ b/galette/lib/Galette/Core/Install.php
@@ -635,7 +635,6 @@ class Install
         $scripts_path = ($spath ?? GALETTE_ROOT . '/install') . '/scripts/';
 
         foreach ($update_scripts as $key => $val) {
-            $sql_query = '';
             if (substr($val, -strlen('.sql')) === '.sql') {
                 //just a SQL script, run it
                 $script = fopen($scripts_path . $val, 'r');
@@ -646,10 +645,15 @@ class Install
                     );
                 }
 
-                $sql_query .= @fread(
+                $sql_query = @fread(
                     $script,
                     @filesize($scripts_path . $val)
                 ) . "\n";
+
+                $sql_res = $this->executeSql($zdb, $sql_query);
+                if (!$sql_res) {
+                    $fatal_error = true;
+                }
             } else {
                 //we got an update class
                 include_once $scripts_path . $val;
@@ -695,13 +699,10 @@ class Install
                 }
             }
 
-            if ($sql_query !== '') {
-                $sql_res = $this->executeSql($zdb, $sql_query);
-                $fatal_error = !$sql_res;
-                if ($fatal_error) {
-                    break;
-                }
-            }
+            Analog::log(
+                str_replace('%s', $key, 'Upgrade to %s complete'),
+                Analog::INFO
+            );
         }
 
         return !$fatal_error;
diff --git a/galette/lib/Galette/Core/Preferences.php b/galette/lib/Galette/Core/Preferences.php
index 8b53e5bd0..6d707f738 100644
--- a/galette/lib/Galette/Core/Preferences.php
+++ b/galette/lib/Galette/Core/Preferences.php
@@ -324,6 +324,9 @@ class Preferences
         $params = array();
         foreach (self::$defaults as $k => $v) {
             if (!isset($this->prefs[$k])) {
+                if ($k == 'pref_admin_pass' && $v == 'admin') {
+                    $v = password_hash($v, PASSWORD_BCRYPT);
+                }
                 $this->prefs[$k] = $v;
                 Analog::log(
                     'The field `' . $k . '` does not exists, Galette will attempt to create it.',
-- 
2.39.2