From 1890e38d5394518be4b3fc4be9d342285c670320 Mon Sep 17 00:00:00 2001 From: Johan Cwiklinski Date: Mon, 15 Jun 2020 07:54:41 +0200 Subject: [PATCH] Errors were not flashed --- .../lib/Galette/Controllers/PdfController.php | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/galette/lib/Galette/Controllers/PdfController.php b/galette/lib/Galette/Controllers/PdfController.php index 172442bb8..966de1787 100644 --- a/galette/lib/Galette/Controllers/PdfController.php +++ b/galette/lib/Galette/Controllers/PdfController.php @@ -585,11 +585,9 @@ class PdfController extends AbstractController $type = (int)$post['model_type']; } + $error_detected = []; if ($type === null) { - $this->flash->addMessage( - 'error_detected', - _T("Missing PDF model type!") - ); + $error_detected[] = _T("Missing PDF model type!"); } else { $class = PdfModel::getTypeClass($type); if (isset($post[PdfModel::PK])) { @@ -621,16 +619,22 @@ class PdfController extends AbstractController _T("Model has been successfully stored!") ); } else { - $this->flash->addMessage( - 'error_detected', - _T("Model has not been stored :(") - ); + $error_detected[] = _T("Model has not been stored :("); } } catch (\Exception $e) { $error_detected[] = $e->getMessage(); } } + if (count($error_detected) > 0) { + foreach ($error_detected as $error) { + $this->flash->addMessage( + 'error_detected', + $error + ); + } + } + return $response ->withStatus(301) ->withHeader('Location', $this->router->pathFor('pdfModels', ['id' => $model->id])); -- 2.39.2