Improve coding standards

[galette.git] / galette / lib / Galette / Filters / ContributionsList.php

diff --git a/galette/lib/Galette/Filters/ContributionsList.php b/galette/lib/Galette/Filters/ContributionsList.php
index 8ed58c9f978d443149efc6ff7a1f97250be94e8f..c07ef4b042d9ff6f3eb59055942a88794c0cbe88 100644 (file)
--- a/galette/lib/Galette/Filters/ContributionsList.php
+++ b/galette/lib/Galette/Filters/ContributionsList.php
@@ -145,13 +145,8 @@ class ContributionsList extends Pagination
      *
      * @return mixed the called property
      */
-    public function __get(string $name)
+    public function __get(string $name): mixed
     {
-        Analog::log(
-            '[ContributionsList] Getting property `' . $name . '`',
-            Analog::DEBUG
-        );
-
         if (in_array($name, $this->pagination_fields)) {
             return parent::__get($name);
         } else {
@@ -189,13 +184,16 @@ class ContributionsList extends Pagination
                     default:
                         return $this->$name;
                 }
-            } else {
-                Analog::log(
-                    '[ContributionsList] Unable to get property `' . $name . '`',
-                    Analog::WARNING
-                );
             }
         }
+
+        throw new \RuntimeException(
+            sprintf(
+                'Unable to get property "%s::%s"!',
+                __CLASS__,
+                $name
+            )
+        );
     }
 
     /**
@@ -225,7 +223,7 @@ class ContributionsList extends Pagination
      *
      * @return void
      */
-    public function __set(string $name, $value): void
+    public function __set(string $name, mixed $value): void
     {
         if (in_array($name, $this->pagination_fields)) {
             parent::__set($name, $value);