Improve coding standards

[galette.git] / galette / lib / Galette / Filters / AdvancedMembersList.php

diff --git a/galette/lib/Galette/Filters/AdvancedMembersList.php b/galette/lib/Galette/Filters/AdvancedMembersList.php
index aab70d6ac3f713d1ee36c150d8bab65f0c6d8d30..852d935cd162e2b6738470f0e85531614ce21db7 100644 (file)
--- a/galette/lib/Galette/Filters/AdvancedMembersList.php
+++ b/galette/lib/Galette/Filters/AdvancedMembersList.php
@@ -297,14 +297,8 @@ class AdvancedMembersList extends MembersList
      *
      * @return mixed the called property
      */
-    public function __get(string $name)
+    public function __get(string $name): mixed
     {
-
-        Analog::log(
-            '[AdvancedMembersList] Getting property `' . $name . '`',
-            Analog::DEBUG
-        );
-
         if (
             in_array($name, $this->pagination_fields)
             || in_array($name, $this->memberslist_fields)
@@ -372,13 +366,16 @@ class AdvancedMembersList extends MembersList
                         return $search_fields;
                 }
                 return $this->$name;
-            } else {
-                Analog::log(
-                    '[AdvancedMembersList] Unable to get property `' . $name . '`',
-                    Analog::WARNING
-                );
             }
         }
+
+        throw new \RuntimeException(
+            sprintf(
+                'Unable to get property "%s::%s"!',
+                __CLASS__,
+                $name
+            )
+        );
     }
 
     /**
@@ -416,7 +413,7 @@ class AdvancedMembersList extends MembersList
      *
      * @return void
      */
-    public function __set(string $name, $value): void
+    public function __set(string $name, mixed $value): void
     {
         global $zdb, $preferences, $login;